Skip to content

fix the bounding box of SOSS#9456

Draft
nden wants to merge 1 commit into
spacetelescope:mainfrom
nden:soss-bbox
Draft

fix the bounding box of SOSS#9456
nden wants to merge 1 commit into
spacetelescope:mainfrom
nden:soss-bbox

Conversation

@nden
Copy link
Copy Markdown
Collaborator

@nden nden commented May 13, 2025 •
edited
Loading

Resolves JP-nnnn

This PR completes work done earlier where a non-coordinate input (spectral_order) is enabled in the the WCS for NIRISS SOSS mode. To complete this a fix in gwcs is needed as well. Related to #9399

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@nden nden requested a review from a team as a code owner May 13, 2025 20:30
@nden nden marked this pull request as draft May 13, 2025 20:30
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.87%. Comparing base (c25698a) to head (1c807f0).
⚠️ Report is 1195 commits behind head on main.

Files with missing lines Patch % Lines
jwst/assign_wcs/niriss.py 0.00% 2 Missing ⚠️
jwst/assign_wcs/assign_wcs.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9456      +/-   ##
==========================================
- Coverage   77.92%   77.87%   -0.05%     
==========================================
  Files         362      362              
  Lines       36279    36333      +54     
==========================================
+ Hits        28269    28295      +26     
- Misses       8010     8038      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke mentioned this pull request May 14, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melanieclarke melanieclarke Awaiting requested review from melanieclarke melanieclarke will be requested when the pull request is marked ready for review melanieclarke is a code owner

@jemorrison jemorrison Awaiting requested review from jemorrison jemorrison will be requested when the pull request is marked ready for review jemorrison is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

assign_wcs NIRISS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nden